bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39452: [PATCH] vc-git-state fails for filenames with wildcards


From: Dmitry Gutov
Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards
Date: Fri, 7 Feb 2020 11:43:36 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 07.02.2020 10:57, Eli Zaretskii wrote:
From: Dmitry Gutov <address@hidden>
Date: Fri, 7 Feb 2020 02:00:38 +0300

I wonder how many other backends commands are broken for files like
that: we basically never shell-quote file names.

Whenever we run commands via the shell, the prudent thing is to always
quote file names (and in general any argument that might include
wildcard characters).  One advantage of call-process is that you don't
have to do that.

It's not so simple. FILE already goes through call-process. But Git expects a pathspec, not just a file name. So if it's a glob, it is expanded.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]