bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39842: [PATCH] Use help-fns-short-filename in other describe- comman


From: Stefan Monnier
Subject: bug#39842: [PATCH] Use help-fns-short-filename in other describe- commands
Date: Sat, 29 Feb 2020 15:02:05 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> Make the other help commands use it, too.

Sounds good.  See a few comments below.

> +;;;###autoload
>  (defun help-fns-short-filename (filename)

OK, we can live that.  Maybe, moving it to help.el would be a cleaner option.

> index 45cbaad4e8..32204d04e3 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -879,6 +879,7 @@ describe-key
>              (princ ", which is ")
>           (describe-function-1 defn)))))))
>  
> +(declare-function help-fns-short-filename "help-fns" (filename))
>  (defun describe-mode (&optional buffer)
>    "Display documentation of current major mode and minor modes.
>  A brief summary of the minor modes comes first, followed by the

The autoload cookie above should render this `declare-function`
unnecessary, right?


        Stefan






reply via email to

[Prev in Thread] Current Thread [Next in Thread]