[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
From: |
Dmitry Gutov |
Subject: |
bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete |
Date: |
Fri, 13 Mar 2020 14:11:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 13.03.2020 0:43, Juri Linkov wrote:
I don't say it's a bad thing, just will make the patch 10 times longer.
Ok, here's the patch that is 10 times longer.
It creates a new function vc-use-vc-dir-on-files
called from vc-next-action that checks whether
the buffer is Dired with marked directories,
Can we create a separate command for Dired buffers instead?
Called dired-vc-next-action. From you earlier description, I imagined
that it would simply invoke a VC-Dir in all cases, but if you need to
check whether there are any directories selected, it would call vc-dir
only in that case, and delegate to vc-next-action otherwise.
That would be a more additive change.
and for optimization returns a list of files
to give to vc-dir via a new arg MARK-FILES.
Then vc-dir let-binds the global variable use-mark-files
exactly the same way as already let-binds use-vc-backend
since there is no other way.
I'd rather look for another way still, without a global var (of this
kind), or passing an argument.
Then vc-dir-refresh puts all marks on files.
Could dired-vc-next-action use vc-delayed, to then run marking code
after the vc-dir buffer refreshes?
Or if it's not working, or not reliable enough, we can add a
vc-dir--after-refresh-hook. Which dired-vc-next-action would add to, and
vc-dir-refresh would run (the function will remove itself from the hook
upon completion).
Also the patch adds a new useful global keybinding 'C-x v V'
bound to vc-next-action-on-root to open *vc-dir* buffer where
all registered files are marked.
Sounds more like vc-dir-root-with-registered-files-selected. I wouldn't
call it "next action" because it only provides one action.
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/09
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/11
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/11
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/12
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete,
Dmitry Gutov <=
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/14
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/15
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/15
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/16
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/24
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/25
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/25
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/29
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/30
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/24