[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range
bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error
Sat, 14 Mar 2020 17:34:46 +0100
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
On Sat, 14 Mar 2020 12:41:34 +0100
Lars Ingebrigtsen wrote:
> Looks like a good fix to me, but is there a reason this is a defsubst
> instead of a defun?
> +(defsubst string-truncate-left (string length)
subr-x is supposed to be loaded at compile time (see the file's
Commentary), so, with the single exception of `replace-region-contents'
(I wonder how that happened...), everything in there is either a macro
or a defsubst.
I would personally welcome lifting that limitation (again, what about
that one exception which needs to load it at run time, anyway?) as IME
it causes confusion with some users and package developers, too, but I'm
not sure that's an option.