[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
From: |
Dmitry Gutov |
Subject: |
bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete |
Date: |
Wed, 25 Mar 2020 23:59:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 25.03.2020 00:36, Juri Linkov wrote:
Finally settled with the following patch.
LGTM, thank you.
Often this is a minor problem, but given the above, a keybinding
like `* u' should be of a little help.
The follow-up patch from the next email look good as well.
- (bindings--define-key map [vc-dir]
- '(menu-item "VC Dir" vc-dir
- :help "Show the VC status of files in a directory"))
+ (bindings--define-key map [vc-dir-root]
+ '(menu-item "VC Dir" vc-dir-root
+ :help "Show the VC status of the repository"))
This part, though... Is it intentional?
I'm all for it personally, but:
- It will need a NEWS entry.
- Are we comfortable with changing the menu entry to the new command,
but keeping the old key binding pointing to the old command? Looks a bit
inconsistent.
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, (continued)
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/27
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/29
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/29
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/29
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/30
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/30
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/30
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Drew Adams, 2020/03/30
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete,
Dmitry Gutov <=
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Juri Linkov, 2020/03/26
- bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete, Dmitry Gutov, 2020/03/26