bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Stefan Kangas]

When running 'make check-all' on master, I get this unexpected result:

Test threads-join-error backtrace:
  signal(ert-test-failed (((should-error (thread-join thread)) :form (
  ert-fail(((should-error (thread-join thread)) :form (thread-join #<t
  (if errorp106 nil (ert-fail (append (funcall form-description-fn-107
  (let ((errorp106 nil) (form-description-fn-107 #'(lambda nil form-de
  (let (form-description-105) (let ((errorp106 nil) (form-description-
  (let ((value-103 'ert-form-evaluation-aborted-104)) (let (form-descr
  (let* ((fn-101 #'thread-join) (args-102 (condition-case err (let ((s
  (let ((thread (make-thread #'threads-call-error))) (while (thread-li
  (lambda nil (let* ((fn-96 #'featurep) (args-97 (condition-case err (
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name threads-join-error :documentation "Te
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(t)
  ert-run-tests-batch-and-exit(t)
  eval((ert-run-tests-batch-and-exit 't) t)
  command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e
  command-line()
  normal-top-level()
Test threads-join-error condition:
    (ert-test-failed
     ((should-error
       (thread-join thread))
      :form
      (thread-join #<thread 0x55c379595b60>)
      :value nil :fail-reason "did not signal an error"))
   FAILED  14/32  threads-join-error (0.000154 sec)

In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version
3.24.18, cairo version 1.16.0)
 of 2020-04-24 built on joffe
Repository revision: 367b55980f9c0c927dce2ba93ab6f626cec6b1fc
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid