[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40940: 27.0.91; project-query-replace-regexp stops too early
From: |
Michael Albinus |
Subject: |
bug#40940: 27.0.91; project-query-replace-regexp stops too early |
Date: |
Wed, 29 Apr 2020 20:38:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 29.04.2020 19:44, Eli Zaretskii wrote:
>> Dmitry, this means my change should be reworked to call
>> expand-file-name before file-local-name, right?
>
> Seems so.
>
> Something like this?
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index dbc967b885..f80b4328bc 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -185,17 +185,16 @@ project--files-in-directory
> (require 'find-dired)
> (require 'xref)
> (defvar find-name-arg)
> - (let* ((default-directory dir)
> - (dirname (file-remote-p dir 'localname))
> - (dirname (or dirname
> - ;; Make sure ~/ etc. in local directory name is
> - ;; expanded and not left for the shell command
> - ;; to interpret.
> - (expand-file-name dir)))
> + (let* ((dir
> + ;; Make sure ~/ etc. in local directory name is
> + ;; expanded and not left for the shell command
> + ;; to interpret.
> + (expand-file-name dir))
> + (default-directory dir)
> (command (format "%s %s %s -type f %s -print0"
> find-program
> - dirname
> - (xref--find-ignores-arguments ignores dirname)
> + dir
> + (xref--find-ignores-arguments ignores dir)
> (if files
> (concat (shell-quote-argument "(")
> " " find-name-arg " "
No. dir is a remote file name. So you must still declare dirname as
(file-local-name dir).
Best regards, Michael.
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, (continued)
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Michael Albinus, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Dmitry Gutov, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Michael Albinus, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Dmitry Gutov, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early,
Michael Albinus <=
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Dmitry Gutov, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Michael Albinus, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/04/29
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Michael Albinus, 2020/04/29