[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#42499: [PATCH] Add Bytecode Offset information to Backtrace

From: Zach Shaftel
Subject: bug#42499: [PATCH] Add Bytecode Offset information to Backtrace
Date: Thu, 23 Jul 2020 19:29:48 -0400
User-agent: mu4e 1.4.10; emacs 28.0.50

This patch adds the offset in a bytecode function's execution where an
error occurs to the *Backtrace* buffer, like this:

Debugger entered--Lisp error: (wrong-type-argument stringp t)
       string-match(t t nil)
    13 test-condition-case()
byte-recompile-file("/home/zach/.repos/bench-compare.el/test/test-debug..." nil 
0 t)
    35 emacs-lisp-byte-compile-and-load()
       call-interactively(emacs-lisp-byte-compile-and-load record nil)
   101 command-execute(emacs-lisp-byte-compile-and-load record)

If you disassemble one of the annotated functions, you can find the
instruction where the error occured.

A 'bytecode_offset' field is added to the 'specbinding.bt' struct, which
holds the offset in the execution of that frame's bytecode function. The
offset for the function being executed is stored in a field of the
'thread_state' struct, and updated from within 'exec_byte_code' before a
funcall. Then 'record_in_backtrace', called by Ffuncall, finds the last
frame and stores the offset there. The frame's offset is added to the
FLAGS plist argument passed by 'mapbacktrace'.

See further discussion about the limitations of the attached
implementation here:

My copyright assignment is still pending so I assume this can't be
merged until I hear back from copyright-clerk. The patch attached is a
simple diff without commit messages. I can add NEWS and Changelog
entries/commit messages if this ends up going through, but I may not be
able to get to that until next week.


Attachment: bytecode-offset-in-backtrace.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]