[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41438: [PATCH] Allow windmove keys to be bound without prefix or mod
bug#41438: [PATCH] Allow windmove keys to be bound without prefix or modifiers
Fri, 07 Aug 2020 02:43:03 +0300
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
>> (I see there were some unfinished parts in your previous patch).
> It's been a while since I submitted it, so I had to re-read the thread,
> but I'm not quite sure what the "unfinished" parts were, aside from the
> missing autoload cookies. Sorry if I missed something :/
I don't know, my impression seems to suggest the first version was not
completely tested, for example, windmove-modifiers defcustom called
windmove-swap-states-default-keybindings, not windmove-default-keybindings.
But maybe you already fixed this.
> Also, the second patch (the one with the user options) depended on the
> previous one in this thread, that introduced the "none" prefix. Is
> that fine, or should I just merge both patches into one.
This is perfectly fine - better to commit two separate patches.