[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone han

From: Eli Zaretskii
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Date: Mon, 10 Aug 2020 19:45:01 +0300

> From: Ulf Jasper <ulf.jasper@web.de>
> Cc: thunk2@arcor.de (Thomas Plass),  34315@debbugs.gnu.org
> Date: Mon, 10 Aug 2020 18:08:34 +0200
> IIRC the patch looked good insofar as it appeared to address only the
> observed problem and to be properly documented and formatted although I
> was not able to reproduce the problem.
> > But then the thread turned towards questions about daylight savings
> > time handling in Windows, and the patch itself wasn't applied?
> Right, the patch was not applied.
> Eli pointed out that the root cause lies in the dst handling in
> ms-windows (and not in newsticker). That makes the patch more of a
> work-around than a fix.
> I admit that I am not very much inclined to check and apply the patch as
> I do not have a ms-windows box to run tests on.
> Eli, what do you think?

My comments were not about the patch (which I admit I don't really
understand, as I don't use icalendar), but about the attempts to see
what happens with time under different TZ settings.

As for the patch, I've looked at it again now, and I don't think it's
specific to MS-Windows, is it?  If so, and if you think it's good,
feel free to install.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]