[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17021: 24.3.50; extension to hi-lock.el

From: David Koppelman
Subject: bug#17021: 24.3.50; extension to hi-lock.el
Date: Thu, 13 Aug 2020 16:46:14 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

I've looked at the patch, but haven't tried to apply it to the current
hi-lock. There are two things that need to be addressed before I would
be happy with it landing.

First, this patch should not include the code for highlighting global
variables, function-like text, and constants. (Perhaps this code was
included by accident.) Those situations are best handled by the
font-lock modes for specific languages.

Second, I don't feel comfortable reading a pattern file path from
within the file being visited. Instead, some kind of identifier could
be read from the file, such as xyz-report-patterns. That identifier
would then be used to locate patterns from a file in some default
location, such as ~/.emacs.d/hi-lock-patterns, or it could be used to
construct a file name (but not a path) that would be expected in some
directory, such as ~/.emacs.d/hi-lock-patterns/.

David Koppelman

reply via email to

[Prev in Thread] Current Thread [Next in Thread]