[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b

From: Stefan Kangas
Subject: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b
Date: Fri, 14 Aug 2020 02:06:46 -0700

close 42168 28.1

Hi Harald,

Harald Jörg <haj@posteo.de> writes:

> Thank you for your thorough review.  I'm rather new to Emacs Lisp, and
> also to the Emacs development workflows, so this is highly
> appreciated.

Happy to help, we've all been there at one point.

>> lisp/progmodes/cperl-mode-tests.el
> I guess this was meant to read test/lisp/progmodes/cperl-mode-tests.el.


> Also, I've added a ChangeLog-style attachment, as suggested by Lars
> Ingebrigtsen in his comment to Bug#42355.


Your diff looks good, so I've installed the attached patch with some
minor fixes, and I'm closing the bug with this message.

Next time, could you please add the ChangeLog entry to the git commit
message and send the result of `git format-patch -1` as an attachment?
That saves time when installing the change.  Please see the attached for
an example, and you can read more in CONTRIBUTE in emacs.git.  It is
also useful to consult the git log for more examples.

Welcome again as an Emacs contributor!

Best regards,
Stefan Kangas

Attachment: 0001-cperl-mode-Highlight-a-b-correctly.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]