|
From: | Dmitry Gutov |
Subject: | bug#42841: 28.0.50; [ruby-mode] ruby-{beginning,end}-of-block doesn't work as is exepected if arguments of method is divided into multi line |
Date: | Sat, 22 Aug 2020 16:30:04 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
Version: 28.1 On 22.08.2020 05:17, Yasuhiro KIMURA wrote:
From: Dmitry Gutov <dgutov@yandex.ru> Subject: Re: bug#42841: 28.0.50; [ruby-mode] ruby-{beginning,end}-of-block doesn't work as is exepected if arguments of method is divided into multi line Date: Sat, 22 Aug 2020 03:26:15 +0300I can't seem to reproduce this. Even after some intensive testing.Wrong type argument: number-or-marker-p, nilCould you perhaps provide a backtrace? Type M-x toggle-debug-on-error, then trigger the error again.I started emacs with '-Q' option and got following backtrace. Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) ruby-move-to-block(1) ruby-end-of-block(1) funcall-interactively(ruby-end-of-block 1) call-interactively(ruby-end-of-block nil nil) command-execute(ruby-end-of-block)
Oh, okay, I see it now. Couldn't reproduce it before because my config contains this line:
(setq ruby-deep-indent-paren (delete ?\( ruby-deep-indent-paren))Which logically shouldn't have any effect because we're not doing any indentation, but unfortunately does.
So I'm going to go ahead and try to fix it by removing the offending code. From some moderate testing, this doesn't seem to have any actual effect on indentation (the non-SMIE variant), and fixes the error. Let's see whether we get any breakage reports later.
Commit 2725254ab5.
[Prev in Thread] | Current Thread | [Next in Thread] |