bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43000: [Web pages] Proposed changes to tour/index.html


From: Thérèse Godefroy
Subject: bug#43000: [Web pages] Proposed changes to tour/index.html
Date: Thu, 27 Aug 2020 14:26:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

Le 26/08/2020 à 23:58, Stefan Kangas a écrit :
[...]
> [Nit. Regarding the "Tour" in #1, it says "(Click on any of these
> pictures for a larger view.)" but the first picture is missing a link.]

Thanks for catching this sneaky bug! It only affects wide screens (above
55em). What happens is that the big numbers are outside the normal flow,
and cover part  of the image. There are 2 ways to fix this:

* Push the numbers to the bottom layer with "z-index: -1".

* Give them enough margin to keep clear of the screenshots (9em works fine).

I chose the first option because it only takes one definition.

>> -<table class="commands">
>> +<table class="commands modes">
>>    <tr><td><kbd>M-x&nbsp;java-mode</kbd></td><td>Mode for editing Java 
>> files</td></tr>
>>    <tr><td><kbd>M-x&nbsp;python-mode</kbd></td><td>Mode for editing Python 
>> files</td></tr>
>>    <tr><td><kbd>M-x&nbsp;text-mode</kbd></td><td>Mode for editing text 
>> files</td></tr>
>> -  <tr><td><kbd>M-x&nbsp;fundamental-mode</kbd></td><td>Mode with no 
>> specializations at all</td></tr>
>> +  <tr><td><kbd>M-x fundamental-mode</kbd></td><td>Mode with no 
>> specializations at all</td></tr>
>>  </table>
> 
> Should the "&nbsp;" really be removed here?

In fact, it doesn't make any difference because the line wraps at the
second dash anyway. I wanted another wrapping point for very narrow
screens, but finally decided to linearize the tables below 35em.

The latest changes are in emacs.2.diff (attached).


I think it would be just as well to use dl lists for all the command
definitions. If the definitions are very short, they can be on the same
line as the command. We can even line them up vertically, table-like.


> I think the proposed changes should be installed.  Thanks again.

Would you like me to install them?

Best,
Thérèse

Attachment: emacs.2.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]