bug#43353: 28.0.50; "make check" fails if there are non-ASCII characters in the Emacs path

[Glenn Morris]

Lars Ingebrigtsen wrote:

> This is because test/Makefile puts a LC_ALL=C thing into the command
> line.

The LC_ALL=C should be removed, as it was from the main lisp Makefile in:
git show d0065ff1244 lisp/Makefile.in
(Ref https://debbugs.gnu.org/15260#82)

> (Which can be overridden by TEST_LOCALE 

(Presumably just an attempt to generalize a feature that should never
have been there.)

> but then a bunch of tests will fail anyway, because a bunch of tests
> assume that we're in the C locale, apparently.)

Most failures were due to text-quoting-style.
For me there are now just two failures left:

1) lisp/vc/diff-mode-tests.log

This failure is due a deficiency of GNU diff, as described in
https://unix.stackexchange.com/questions/603249/how-to-make-diff-print-non-ascii-characters-in-file-names

It means that the file names returned by diff-hunk-file-names cannot be
found, so diff-syntax-fontify-hunk does nothing.

Perhaps diff-hunk-file-names should decode the diff header to work
around the GNU diff issue.

2) tramp-archive-test02-file-name-dissect
due to some extra "%25" in host as compared to url-hexify-string.

Perhaps there are more failures in check-expensive, but life's too short.