[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction
From: |
No Wayman |
Subject: |
bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction |
Date: |
Thu, 17 Sep 2020 13:09:13 -0400 |
User-agent: |
mu4e 1.5.5; emacs 28.0.50 |
Lars Ingebrigtsen <larsi@gnus.org> writes:
Thanks for the feedback, Lars.
Warnings are something you should rarely get, so I'm not quite
sure I
see the use case for this? In any case, some minor comments...
The same argument could be made against the buttons/suppression
themselves:
"Warnings are something you should rarely get, so I'm not quite
sure I see the use case for suppressing them."
I don't see either as a particularly strong argument.
For me, the buttons are useless because I have `custom-file` set
to `null-device'.
They just add visual clutter to the buffer in that case.
The customization seems pretty low-cost in terms of
complexity/maintenance IMO and provides the flexibility
to accommodate my (and possibly other we haven't thought of) use
cases.
And perhaps this would be clearer as a (when (and .. instead.
Addressed by changing the customization to
`warning-hide-suppression-buttons' and inverting the semantics in
the attached patch.
0001-warning-hide-suppression-buttons.patch
Description: warning-hide-suppression-buttons