[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41633: Prompts incorrect for multi-occur and multi-isearch when usin
From: |
Juri Linkov |
Subject: |
bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode |
Date: |
Sun, 04 Oct 2020 22:31:09 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
reopen 41633
quit
> For two, the check for ido-mode is actually broken, but I don’t yet know
> how to fix it. It does (eq read-buffer-function #'ido-read-buffer), but
> actually nowadays (maybe this was different in the past), ido-mode doesn’t
> set read-buffer-function, unless you call ido-everywhere, and then it still
> doesn’t set it but overrides it with an advice, so that its value is
> #f(advice-wrapper :override nil ido-read-buffer), and this fails the
> eq test.
>
> Anyway, I’d suggest applying this patch for now, and then figuring out
> how to fix the check for ido.
I confirm it doesn't work with ido-everywhere.
Maybe this is a better condition?
diff --git a/lisp/replace.el b/lisp/replace.el
index 4883ecfc8f..b717a2a25c 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1588,7 +1588,7 @@ multi-occur--prompt
(concat
"Next buffer to search "
(cond
- ((eq read-buffer-function #'ido-read-buffer)
+ ((bound-and-true-p ido-everywhere)
(substitute-command-keys
"(\\<ido-completion-map>\\[ido-select-text] to end): "))
((bound-and-true-p fido-mode)
- bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode,
Juri Linkov <=