[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44411: 28.0.50; uudecode-decode-region-internal is broken
From: |
Lars Ingebrigtsen |
Subject: |
bug#44411: 28.0.50; uudecode-decode-region-internal is broken |
Date: |
Tue, 03 Nov 2020 16:09:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Kazuhiro Ito <kzhr@d1.dion.ne.jp> writes:
> The function makes string from uuencoded text by passing unsigned char
> vlue (0-255) to char-to-string function, which makes multibyte-string.
> After that, string is decoded as binary. But eight-bit characters are
> never made in that way.
>
> (let ((ch #xc8))
> (decode-coding-string (char-to-string ch) 'binary))
>
> -> "8"
>
> Additionally, concat and char-to-string functions are called so
> frequently that deocder is very slow for large data.
>
> Please see the below patch.
Thanks; looks good to me. This patch is slightly too large to apply
without having an FSF copyright on file, and I don't see that in the
assignment file for you.
Would you be willing to sign such paperwork so that we can get the patch
applied?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Kazuhiro Ito, 2020/11/03
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken,
Lars Ingebrigtsen <=
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Eli Zaretskii, 2020/11/03
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Kazuhiro Ito, 2020/11/04
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Eli Zaretskii, 2020/11/04
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Kazuhiro Ito, 2020/11/05
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Eli Zaretskii, 2020/11/05
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Eli Zaretskii, 2020/11/07
- bug#44411: 28.0.50; uudecode-decode-region-internal is broken, Kazuhiro Ito, 2020/11/09