[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-pr
|
From: |
Protesilaos Stavrou |
|
Subject: |
bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-print-root-log |
|
Date: |
Sat, 28 Nov 2020 20:56:32 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On 2020-11-28, 20:13 +0200, Dmitry Gutov <dgutov@yandex.ru> wrote:
> On 03.11.2020 19:23, Protesilaos Stavrou wrote:
>> What do you think?
>
> I think the idea is good, but the change in the looks is a bit questionable.
>
> Can we do it without the grey background? It's kind of weird to see it
> surrounded by "unexpanded" log entries that use the default white
> background. And other windows that mostly use the white background.
>
> As we can see on the screenshots you posted yourself, the "before" one looks
> more uniform than the "after".
>
> If there are no alternative ideas on which colors to pick, we can just inherit
> from font-lock-comment-face, to retain the previous looks.
I think inheriting from font-lock-comment-face is the best option.
Should I send a patch or you can handle it?
--
Protesilaos Stavrou
protesilaos.com