[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44885: 28.0.50; [PATCH] ElDoc buffer mode and separator
From: |
Basil L. Contovounesios |
Subject: |
bug#44885: 28.0.50; [PATCH] ElDoc buffer mode and separator |
Date: |
Sun, 29 Nov 2020 13:02:25 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
> * lisp/emacs-lisp/eldoc.el (eldoc-doc-buffer-separator): New option.
Does this need calling out in etc/NEWS?
> + (define-key map [?\S-\ ] 'scroll-down-command)
Nit: please prefer '\s' over '\ '.
> +(define-derived-mode eldoc-doc-mode fundamental-mode "ElDoc doc"
> + "Major mode for ElDoc documentation buffer."
If it's the major mode for the ElDoc buffer, why not call it
eldoc-buffer-mode so as to avoid the repetition/ambiguity of "doc"?
> + (setq buffer-read-only t))
> +
> (defun eldoc--format-doc-buffer (docs)
> "Ensure DOCS are displayed in an *eldoc* buffer."
> (interactive (list t))
> @@ -472,12 +495,13 @@ eldoc--format-doc-buffer
> eldoc--doc-buffer
> (setq eldoc--doc-buffer
> (get-buffer-create " *eldoc*")))
> + (unless (eq major-mode 'eldoc-doc-mode)
Why not derived-mode-p?
Thanks,
--
Basil