[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompat
From: |
Protesilaos Stavrou |
Subject: |
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) |
Date: |
Thu, 10 Dec 2020 13:46:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On 2020-12-10, 02:25 -0600, Stefan Kangas <stefankangas@gmail.com> wrote:
> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> I agree that putting them all under lisp/ is not the right way to go
>> right now. Today I will experiment with placing the libraries in
>> lisp/themes and the derivatives in etc/themes. This will obfuscate the
>> source code though, but I will try nonetheless and report back to you
>> (without prejudice to any other ideas you or someone else may have).
>
> Thanks! Looking forward to seeing the new version in Emacs.
>
> Could you explain how it would obfuscate the source code? I'm not sure
> I understand that part.
I followed your advice in reviewing my patch. Please find it attached.
In short:
+ The 'modus-operandi-theme' and 'modus-vivendi-theme' are in
etc/themes.
- Standard commands like 'load-theme' and 'enable-theme' work as
intended.
- Theme-level functions/commands, such as 'modus-themes-toggle' work
as expected.
+ The other two files, 'modus-themes-core.el' and 'modus-themes.el' are
placed under lisp/themes.
Note I tried to edit the texi file in light of bug#45141 and I think I
did everything right, but I cannot run that command locally---it is slow
and my hardware's temparature rises considerably. Perhaps the texi file
needs to be edited further, in which case I am prepared to do whatever
is necessary (and apologies in advance for taking too much out of your
time).
* * *
On the "obfuscation" point I mentioned before: I expressed myself
poorly. What I thought was that it would be difficult to study the
theme's code, but one upside (I think) of the aforementioned changes is
that M-x find-library now lists the files I placed in lisp/themes.
--
Protesilaos Stavrou
protesilaos.com
0001-Update-Modus-themes-1.0.2-backward-incompatible.patch
Description: Text Data
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2020/12/06
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2020/12/08
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/09
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2020/12/10
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/10
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible),
Protesilaos Stavrou <=
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Juri Linkov, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Christopher Dimech, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Christopher Dimech, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2020/12/11