|
From: | Dmitry Gutov |
Subject: | bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal |
Date: | Fri, 18 Dec 2020 04:06:05 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 18.12.2020 01:25, Glenn Morris wrote:
fda9a2 causes a test failure. Ref eg:https://hydra.nixos.org/build/132986117
Thanks! It was a curious bug: one would expect that some highlighting's boundaries might change. What changed, however, is one's _type_.
I've pushed a fix, and I'll let the Flymake's maintainer sort out at his leisure whether flymake-diag-region can be relied on not to change match data, as several of its clients seem to assume.
(Are people trying to run foo-tests.el before pushing changes to foo.el?)
Some of us are spoiled enough to expect an email from the CI when some breakage occurs.
(Sorry.)
[Prev in Thread] | Current Thread | [Next in Thread] |