[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45562: [PATCH] Fix "comparison always the same" warnings found by lg
|
From: |
Andreas Schwab |
|
Subject: |
bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm |
|
Date: |
Fri, 01 Jan 2021 17:38:28 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) |
On Jan 01 2021, Stefan Kangas wrote:
>>> --- a/src/fns.c
>>> +++ b/src/fns.c
>>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to,
>>> ptrdiff_t length,
>>> if (c == '=')
>>> continue;
>>>
>>> - if (v1 < 0)
>>> - return -1;
Looking at commit 5abaea334cf, that likely needs to test v1 == 0 instead.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."