bug#46534: Lexical change in bindat breaks weechat.el

[Tony Olagbaiye]

Hi,

As of commit c8c4d65d6510724acd40527a9af67e21e3cf4d5e (as bisected in my stead by wasamasa on #emacs) it seems bindat changes have broken weechat.el, or specifically the weechat-relay module.

Attached a minimal reproducible script which fails on master but succeeds prior to the mentioned commit: weechat-bindat.bug.el.txt

Backtrace:

Debugger entered--Lisp error: (void-variable struct) (bindat-get-field struct 'len) (weechat--relay-bindat-unsigned-to-signed (bindat-get-field struct 'len) 4) (let ((len (weechat--relay-bindat-unsigned-to-signed (bindat-get-field struct 'len) 4))) (if (<= len 0) 0 len)) bindat--unpack-group(((len u32) (val str (eval (let ((len (weechat--relay-bindat-unsigned-to-signed ... 4))) (if (<= len 0) 0 len)))))) bindat--unpack-group(((length u32) (compression u8) (id struct weechat--relay-str-spec) (data vec (eval (let ((l (- ... 4 1 ...))) l))))) bindat-unpack(((length u32) (compression u8) (id struct weechat--relay-str-spec) (data vec (eval (let ((l (- ... 4 1 ...))) l)))) "\0\0\0$\0\0\0\0\4G255inf\0\0\0\7version\0\0\0\0053.0.1") weechat-unpack-message("\0\0\0$\0\0\0\0\4G255inf\0\0\0\7version\0\0\0\0053.0.1") weechat--relay-parse-new-message() weechat--relay-process-filter(#<process weechat-relay-tls> "\0\0\0$\0\0\0\0\4G255inf\0\0\0\7version\0\0\0\0053.0.1")

Best,
bqv

weechat-bindat.bug.el.txt
Description: Text document

publickey - EmailAddress(s=me@fron.io) - 0x3026807C.asc
Description: application/pgp-keys

signature.asc
Description: OpenPGP digital signature