|
From: | Dmitry Gutov |
Subject: | bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el |
Date: | Tue, 2 Mar 2021 23:37:45 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
Hi Theodor,On 02.03.2021 23:13, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
Yeah, maybe. However, without benchmarking, it is quite clear that adding your option is faster than my patch, since ripgrep has to search the whole minified file. I assume it short circuits, so that results are delivered quicker to emacs. Maybe this bug can be closed.
Could you try benchmarking both approaches?If the performance improvement from yours is at all comparable with Juri's, I'm inclined to prefer that direction for reasons described in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44983#71.
In both cases Ripgrep (or Grep) will search the whole file. The -M flag just affects its output.
[Prev in Thread] | Current Thread | [Next in Thread] |