[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47167: [External] : bug#47167: Multi-line comment-region with empty
From: |
Drew Adams |
Subject: |
bug#47167: [External] : bug#47167: Multi-line comment-region with empty comment-continue |
Date: |
Tue, 16 Mar 2021 19:24:47 +0000 |
> > (Haven't looked at your patch.)
> > Sounds like a reasonable, and useful thing to do.
> >
> > However, `comment-region' also has optional behaviors
> > that involve its use of a prefix arg. How with those
> > interact with what you propose? Do they even make
> > sense (e.g. nesting comment levels and unnesting them)?
>
> With (setq-local comment-style 'extra-line comment-continue ""),
> `comment-region' currently breaks HTML syntax
> because HTML doesn't support nested comments:
>
> <!--
> <!-- line 1 -->
> <!-- line 2 -->
> <!-- line 3 -->
> -->
>
> With the proposed patch, HTML syntax stays valid:
>
> <!--
> line 1
> line 2
> line 3
> -->
I see, I guess. But why change `comment-region',
instead of creating a new command for multi-line
(aka block) commenting?
If there's a bug now (e.g. wrt `comment-continue')
when someone uses `comment-region', then maybe
either that can be fixed (without involving
multiline) or that command can be made to ignore,
DTRT, or raise an error when `comment-continue'
is used. (Just a wild guess, without looking at
any code.)