[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47234: 28.0.50; frame-inner-height fails without window system on ta
From: |
Eli Zaretskii |
Subject: |
bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height |
Date: |
Thu, 18 Mar 2021 16:30:43 +0200 |
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Thu, 18 Mar 2021 13:41:04 +0000
> Cc: juri linkov <juri@linkov.net>
>
> In a build --without-x:
>
> 0. ./src/emacs -Q
> 1. (frame-inner-height) C-j
>
> Debugger entered--Lisp error: (void-function tab-bar-height)
> tab-bar-height(#<frame F1 0x55aeb85320a0> t)
> frame-inner-height()
> (progn (frame-inner-height))
> eval((progn (frame-inner-height)) t)
> elisp--eval-last-sexp(t)
> eval-last-sexp(t)
> eval-print-last-sexp(nil)
> funcall-interactively(eval-print-last-sexp nil)
> call-interactively(eval-print-last-sexp nil nil)
> command-execute(eval-print-last-sexp)
>
> The obvious band-aid is to check (fboundp 'tab-bar-height) in
> frame-inner-height, but shouldn't we count 1 line when tab-bar-mode is
> enabled even --without-x? IOW, can/should tab-bar-height or similar be
> defined regardless of HAVE_WINDOW_SYSTEM? What's TRT here?
TRT is to teach Emacs to return the tab-bar height on TTY frames as
well. But I don't think defining tab-bar-height on TTY frames is the
right way: the tab-bar is always 1 line high on those frames, so we
could simply use that hardcoded value instead of signaling an error, I
think.
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Basil L. Contovounesios, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height,
Eli Zaretskii <=
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Basil L. Contovounesios, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Eli Zaretskii, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Basil L. Contovounesios, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Eli Zaretskii, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Juri Linkov, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, martin rudalics, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Eli Zaretskii, 2021/03/18
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, martin rudalics, 2021/03/19
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Eli Zaretskii, 2021/03/19
- bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height, Eli Zaretskii, 2021/03/18