[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47320: Improve failure reporting in test/lisp/electrict-tests.el
From: |
Alan Mackenzie |
Subject: |
bug#47320: Improve failure reporting in test/lisp/electrict-tests.el |
Date: |
Wed, 24 Mar 2021 19:42:54 +0000 |
Hello again, João.
On Wed, Mar 24, 2021 at 14:02:58 +0000, João Távora wrote:
> On Wed, Mar 24, 2021 at 1:46 PM Alan Mackenzie <acm@muc.de> wrote:
> > I'm having some difficulty getting my head around the "explanation"
> > functionality of ert, which leans me towards my initial plan.
> > Here's the patch (actually written quite a long time ago) I would like to
> > merge into electric-tests.el:
> As far as I understand, this just stores the big explanation string in
> a variable, and uses it both for putting into the `ert-deftest` 's docstring
> as well as for logging with message(), right? If so, it's fine to add.
> Maybe you could leverage `ert-fail` instead of checking the test's
> main assertion twice, once in should, and once when deciding
> whether to log.
In the end, I couldn't get that to work - the handler for the signal, in
outputting the doc string, replaced all the \n's with the octal
read-syntax, "\\12". This left the text readable only with effort.
> I'd say, just check it once and put both logging and `ert-fail` inside the if.
I just committed the patch as it was. Sorry.
> João
--
Alan Mackenzie (Nuremberg, Germany).
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, Alan Mackenzie, 2021/03/22
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, Michael Albinus, 2021/03/23
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, Alan Mackenzie, 2021/03/23
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, Michael Albinus, 2021/03/23
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, João Távora, 2021/03/23
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, Alan Mackenzie, 2021/03/24
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, João Távora, 2021/03/24
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el,
Alan Mackenzie <=
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, João Távora, 2021/03/24
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, Alan Mackenzie, 2021/03/25
- bug#47320: Improve failure reporting in test/lisp/electrict-tests.el, João Távora, 2021/03/25