bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#47074: Replace XPM icons with Unicode codepoints in customize/widget


From: Eli Zaretskii
Subject: bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets
Date: Sun, 04 Apr 2021 14:55:41 +0300

> Date: Sun, 4 Apr 2021 12:44:00 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: stefan@marxist.se, 47074@debbugs.gnu.org
> 
> > Alan, this patch calls malloc to allocate face_font_family, but then
> > calls xfree to free it.  Why didn't you call xmalloc to allocate?
> > that's currently the only caller of malloc in the entire image.c.
> 
> I originally used malloc, then realised every other call is to xmalloc
> and thought I'd fixed them all.

OK, I fixed.

> This change appears to have been particularly bad, apologies to
> everyone for the mess I've caused.

No need to apologize, thanks for your work.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]