[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartr
From: |
Dmitry Gutov |
Subject: |
bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' |
Date: |
Sat, 10 Apr 2021 04:40:49 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 08.04.2021 21:57, Juri Linkov wrote:
Thanks for the detailed test case. Now it's fixed in 580c4c6510.
Thanks! repeat-mode is looking good now (*).
I've added integration for it to diff-hl master, and with that we can
close this issue.
Thanks all.
(*) Though the first impression, in comparison, was that it is too
chatty. The hints are definitely helpful for discovery at first, though.
Maybe something like this would be an improvement? Experimental code
warning.
diff --git a/lisp/repeat.el b/lisp/repeat.el
index b3c58f2f81..e704e4da56 100644
--- a/lisp/repeat.el
+++ b/lisp/repeat.el
@@ -404,7 +404,7 @@ repeat-post-hook
(key-description repeat-exit-key))
""))))
(if (current-message)
- (message "%s [%s]" (current-message) mess)
+ (message #("%s [%s]" 3 7 (face deemphasized))
(current-message) mess)
(message mess))))
;; Adding an exit key
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Ramesh Nedunchezian, 2021/04/02
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Dmitry Gutov, 2021/04/03
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Juri Linkov, 2021/04/05
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Dmitry Gutov, 2021/04/06
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Juri Linkov, 2021/04/08
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep',
Dmitry Gutov <=
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Ramesh Nedunchezian, 2021/04/10
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Juri Linkov, 2021/04/10
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Ramesh Nedunchezian, 2021/04/11
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Juri Linkov, 2021/04/11
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Juri Linkov, 2021/04/12
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Juri Linkov, 2021/04/10
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Dmitry Gutov, 2021/04/10
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Juri Linkov, 2021/04/12
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Dmitry Gutov, 2021/04/13
- bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep', Kévin Le Gouguec, 2021/04/14