[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47879: [PATCH] Ignore mode hooks when analysing diffs
From: |
Eli Zaretskii |
Subject: |
bug#47879: [PATCH] Ignore mode hooks when analysing diffs |
Date: |
Sun, 18 Apr 2021 22:25:11 +0300 |
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Sun, 18 Apr 2021 19:08:01 +0000
>
> This fixes a bug related to log-edit-generate-changelog-from-diff.
>
> When I tried to invoke this command in a commit buffer, the error
>
> signal: Unmatched bracket or quote
>
> was raised. The reason was that I added paredit-mode to
> emacs-lisp-mode-hook, that when invoked calls check-parens. This raises
> an error when the diff contains a partial s-expression, which is almost
> always the case.
>
> The least invasive approach I could come up with was to defer the mode
> hooks.
I rather think that the bug is either in the hook you added or in
paredit-mode, and should be solved there. Otherwise, we'd need to
defer hooks every time we turn on a mode. And who known what
deferring all the hooks could do to other hooks, which are entirely
legitimate and don't cause any problems.
IOW, I think what you suggest is too blunt a weapon, and could do more
harm than help. Let's try to find a cleaner way of fixing the
problem, preferably where it happens, i.e. in the code that is run by
the hook.
Thanks.
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Philip Kaludercic, 2021/04/18
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs,
Eli Zaretskii <=
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Philip Kaludercic, 2021/04/18
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Stefan Kangas, 2021/04/21
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Eli Zaretskii, 2021/04/21
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Philip Kaludercic, 2021/04/21
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Stefan Kangas, 2021/04/21
- bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Philip Kaludercic, 2021/04/21
bug#47879: [PATCH] Ignore mode hooks when analysing diffs, Philipp Stephani, 2021/04/18