[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command
From: |
Eli Zaretskii |
Subject: |
bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command |
Date: |
Mon, 03 May 2021 15:09:01 +0300 |
> From: martin rudalics <rudalics@gmx.at>
> Date: Mon, 3 May 2021 14:02:13 +0200
> Cc: Robert Marshall <robert@capuchin.co.uk>, 47969@debbugs.gnu.org
>
> > Okay, I bisected this, and the culprit is commit 3fdd3bb56c.
> Interestingly, that commit removed the following from handle-select-window:
> >
> > ;; Don't switch if we're currently in the minibuffer.
> > ;; This tries to work around problems where the
> > ;; minibuffer gets unselected unexpectedly, and where
> > ;; you then have to move your mouse all the way down to
> > ;; the minibuffer to select it.
> > (window-minibuffer-p)
> >
> > which happens to be what my patch adds again.
>
> I can't give a reasonable explanation why I removed that back then, so
> please re-add it as soon as your paperwork is done.
I'd actually trust your-then judgment, and instead explore the
possibility of solving this as I proposed up-thread. Undoing past
fixes when we don't understand the effects is bad mantra, it runs the
risk of fixing one problem by reintroducing another.
> And many thanks for the bisection, great work as usual.
Seconded.
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, (continued)
bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, martin rudalics, 2021/05/02
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Robert Marshall, 2021/05/02
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, martin rudalics, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, martin rudalics, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command,
Eli Zaretskii <=
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, martin rudalics, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Eli Zaretskii, 2021/05/03
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/04
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Eli Zaretskii, 2021/05/04
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/04
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Eli Zaretskii, 2021/05/04
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/04
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Eli Zaretskii, 2021/05/04
- bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command, Gregory Heytings, 2021/05/04