bug#41200: Displaying a tooltip with x-show-tip gets very slow as more faces are defined

[Jashank Jeremy]

At 2021-04-22 23:56:20 -0400, Stefan Monnier wrote:
> [...] most faces that don't use colors: the *scratch* buffer's
> comments are displayed in black+bold+italic, the mode-line has a black
> background.  A call of the form `(error "foo")` has foo display in
> black+italic and the `error symbol is displayed in reverse video
> (black background).

At 2021-05-12 22:29:47 +0200, Lars Ingebrigtsen wrote:
> I tried the patch, too, and I'm seeing the same -- most faces are
> different than they used to be, which is surely not what's supposed to
> happen.

But another experiment you could try: create a new frame.  And another.

OK, I'll spoil the surprise --- this misbehaviour occurs *only* on the
initial frame.  I don't precisely know _why_ that happens, but I do know
how it broke: I tried (and thought I had succeeded) fixing a bug that
occurred only when reverse video was enabled, which would stop creation
of new frames entirely.

> Jashank, have to continued working on this patch?

Yes --- I have a patched patch which fixes that behaviour.

The 10th revision of that patch is attached: I have been running it for
a few weeks atop 7c901d90e620b4d3651b86c13faf1e81eeb3db10 (master at the
time), so I can tell you it also works with native-compile.

I have rebased onto ec574a72f7198d9793b466f33382fff397ac4ce1 (master as
of now) and will test that.

Cheers,
    ~jashank

0001-Store-frame-faces-in-hash-tables-instead-of-alists-V10.patch
Description: Text Data

pgpo5ewzaaQ9i.pgp
Description: OpenPGP Digital Signature