[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48902: 28.0.50; Directory names containing apostrophes and backticks
From: |
naofumi |
Subject: |
bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems |
Date: |
Tue, 08 Jun 2021 12:39:19 +0200 |
User-agent: |
SOGoMail 5.1.1 |
On Monday, June 07, 2021 16:15 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Lars Ingebrigtsen <larsi@gnus.org>
> > ... so perhaps it's only a problem for the Macos build?
>
> I suspect it has to do with the special way macOS encodes non-ASCII
> file names.
>
I found the same issue with images which has Japanese filename on macOS.
Message buffer says:
------------------------------------------------------------------------
Unable to load image (image :type png :file
/Users/naofumi/_git/git.sv.gnu.org/emacs_png/いーまっくす.png :scale 1 :max-width 480
:max-height 781 :format nil :transform-smoothing t) [5 times]
------------------------------------------------------------------------
At least, attached small patch could fix this.
attachments:
0001-Fix-to-show-images-with-non-ascii-filename-on-macOS.patch
ns_load_image-error-with-non-ascii-filename.png
revert-filename-NSString-in-nsimage.png
emacs_png.tar.gz
This [EmacsImage allocInitFromFile:] change was introduced by the
following commit:
------------------------------------------------------------------------
commit 747a923b9a35533f98573ad5b01fccf096195079
Author: Alan Third <alan@idiocy.org>
Date: Tue Dec 22 23:28:25 2020 +0000
Use new NSString lisp methods
* src/nsfont.m (ns_otf_to_script):
(ns_registry_to_script):
(ns_get_req_script): Use NSString conversion methods.
* src/nsimage.m ([EmacsImage allocInitFromFile:]): Use NSString
conversion methods.
* src/nsmenu.m (ns_menu_show): Use NSString conversion methods. *
src/nsselect.m (symbol_to_nsstring):
(ns_string_to_pasteboard_internal): Use NSString conversion methods.
* src/nsterm.m (ns_term_init):
([EmacsView initFrameFromEmacs:]): Use NSString conversion methods. *
src/nsxwidget.m (nsxwidget_webkit_uri):
(nsxwidget_webkit_title):
(js_to_lisp): Use NSString conversion methods.
(build_string_with_nsstr): Functionality replaced by NSString extensions.
------------------------------------------------------------------------
Regards,
--Naofumi
emacs_png.tar.gz
Description: GNU Zip compressed data
0001-Fix-to-show-images-with-non-ascii-filename-on-macOS.patch
Description: Binary data
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Rudolf Adamkovič, 2021/06/07
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Lars Ingebrigtsen, 2021/06/07
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Eli Zaretskii, 2021/06/07
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems,
naofumi <=
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Lars Ingebrigtsen, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Alan Third, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Lars Ingebrigtsen, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Mattias Engdegård, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Eli Zaretskii, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, naofumi, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Mattias Engdegård, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Alan Third, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Mattias Engdegård, 2021/06/08
- bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems, Alan Third, 2021/06/08