bug#49449: 28: TLS connection never gets to "open" stage

[Mattias Engdegård]

11 juli 2021 kl. 17.01 skrev Eli Zaretskii <eliz@gnu.org>:

>> I still favour the less intrusive patch posted previously (adding a 
>> condition at line 5235) since it avoids duplication; there is already far 
>> too much of that in the code (everything seems to be done in at least two 
>> places). The code is obviously in the need of restructuring, but we 
>> shouldn't conflate that effort with fixing this specific bug.
> 
> I tend to agree.

Attached is the patch that I intend to push if there are no objections. The 
actual change is the same as before and I anticipate no trouble arising from it 
but tests are usually more fragile.

This issue could very well be the root cause of or at least connected to other 
bugs: maybe bug#36017 or bug#34341? In any case it's good to see it fixed; it 
annoyed me (with GNU ELPA in particular) for quite some time and the various 
unsatisfactory workarounds suggested each time this came up (such as using HTTP 
instead of HTTPS) are no longer required.

0001-Block-TLS-handshake-until-TCP-connection-established.patch
Description: Binary data