[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#6803: 24.0.50; pc-selection-mode no longer plays nice with dired (or
bug#6803: 24.0.50; pc-selection-mode no longer plays nice with dired (or vice versa)
Sun, 18 Jul 2021 14:57:26 +0200
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Juanma Barranquero <email@example.com> writes:
> On Thu, Aug 5, 2010 at 13:07, Tim Van Holder <firstname.lastname@example.org> wrote:
>> Dired normally has the up and down arrows bound to dired-previous-line
>> (also bound to [p]) and dired-next-line (also bound to [n]), respectively.
>> However, when pc-selection-mode is enabled, these bindings are
>> apparently overridden now, to previous-line-nomark and next-line-nomark,
>> respectively, breaking the normal dired navigation (point is not
>> automatically put on the file name).
>> Looking at 'C-h m' for dired in an older emacs version (a 184.108.40.206
>> build) and today's bzr head, the cause seems to be that while the older
>> dired explicitly bound <up> and <down>, the current dired seems to rely
>> on remapping <next-line> and <previous-line> instead.
> Right, this is a consequence of bug#6632 and revno:100864.
> Perhaps it should be reverted, but then, the use case mentioned in the
> bug will still be there.
This was ten years ago, and nobody had any opinions. The patch in
question removed the direct bindings...
We allow modes all over the place to bind `C-n' (there's apparently
around 100 of these in the Emacs tree), so I don't think Dired was doing
anything wrong here.
I haven't looked at pc-selection-mode, though -- is this problem still
present in recent Emacs versions?
diff --git a/lisp/dired.el b/lisp/dired.el
index c3d1435..0e5cc22 100644
@@ -1380,10 +1380,8 @@ Do so according to the former subdir alist
(define-key map ">" 'dired-next-dirline)
(define-key map "^" 'dired-up-directory)
(define-key map " " 'dired-next-line)
- (define-key map "\C-n" 'dired-next-line)
- (define-key map "\C-p" 'dired-previous-line)
- (define-key map [down] 'dired-next-line)
- (define-key map [up] 'dired-previous-line)
+ (define-key map [remap next-line] 'dired-next-line)
+ (define-key map [remap previous-line] 'dired-previous-line)
(define-key map "$" 'dired-hide-subdir)
(define-key map "\M-$" 'dired-hide-all)
@@ -1393,7 +1391,7 @@ Do so according to the former subdir alist
(define-key map (kbd "M-s f C-s") 'dired-isearch-filenames)
(define-key map (kbd "M-s f M-C-s") 'dired-isearch-filenames-regexp)
- (define-key map "\C-x\C-q" 'dired-toggle-read-only)
+ (define-key map [remap toggle-read-only] 'dired-toggle-read-only)
(define-key map "?" 'dired-summary)
(define-key map "\177" 'dired-unmark-backward)
(define-key map [remap undo] 'dired-undo)
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
|[Prev in Thread]
||[Next in Thread]|
- bug#6803: 24.0.50; pc-selection-mode no longer plays nice with dired (or vice versa),
Lars Ingebrigtsen <=