bug#50290: Using `setf` on `map-elt` repeats evaluation for returning the value of `setf`

[Lars Ingebrigtsen]

Okamsn <okamsn@protonmail.com> writes:

> When I do `(setf (map-elt map key) (my-func))`, it expands to
>
>      (let* ((key key))
>        (condition-case nil
>            (with-no-warnings
>              (map-put! map key (my-func) nil))
>          (map-not-inplace
>           (setq map (map-insert map key (my-func)))
>           (my-func))))
>
> The repetition of `(my-func)` raises warnings. 

Yup.  This should now be fixed on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no