[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50256: thing-at-mouse
From: |
Juri Linkov |
Subject: |
bug#50256: thing-at-mouse |
Date: |
Thu, 02 Sep 2021 21:28:32 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
>> I mean that we needn't do that because pos_visible_p already does it.
>> So I'd just propose to do the trivial (line numbers are not trunk's);
>>
>> diff --git a/src/window.c b/src/window.c
>> index cb8fe5fcdb..bfbed01749 100644
>> --- a/src/window.c
>> +++ b/src/window.c
>> @@ -2199,8 +2199,6 @@ DEFUN ("pos-visible-in-window-p",
>> Fpos_visible_in_window_p,
>> posint = -1;
>> else if (!NILP (pos))
>> posint = fix_position (pos);
>> - else if (w == XWINDOW (selected_window))
>> - posint = PT;
>> else
>> posint = marker_position (w->pointm);
>
> I confirm this fixes the reported issues.
Actually, whereas it fixes the reported issue,
it breaks everything else: moving point up and down
always jumps to the fixed column like goal-column,
selecting a completion from the Completions buffer
always says "No completion here", 'C-c C-c' in diff-mode
jumps to the wrong hunk, etc.
- bug#50256: thing-at-mouse, (continued)
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/02
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/02
- bug#50256: thing-at-mouse, Lars Ingebrigtsen, 2021/09/02
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/02
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/02
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/02
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/02
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/02
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/02
- bug#50256: thing-at-mouse, Juri Linkov, 2021/09/02
- bug#50256: thing-at-mouse,
Juri Linkov <=
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/02
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/03
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/03
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/04
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/04
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/04
- bug#50256: thing-at-mouse, Eli Zaretskii, 2021/09/04
- bug#50256: thing-at-mouse, Juri Linkov, 2021/09/04
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/05
- bug#50256: thing-at-mouse, martin rudalics, 2021/09/05