bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50340: Fix remote-location in vc-git-log-incoming


From: Juri Linkov
Subject: bug#50340: Fix remote-location in vc-git-log-incoming
Date: Fri, 03 Sep 2021 11:12:40 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

>> -  (vc-git-command nil 0 nil "fetch")
>> +  (vc-git-command nil 0 nil "fetch" (unless (string= remote-location "")
>> +                                      remote-location))
>
> I'm not sure which scenario this fixes (pressing RET after 'C-u C-x v I'
> works fine here), but it shouldn't hurt either.

It fixes the scenario with a non-default remote.  Could you try 'C-u C-x v I'
and typing the name of a non-default remote in a repo with two remotes?
I wonder if it already worked, and maybe I have some misconfiguration.

> So if you have a stable repro (some alternative completing-read-function?),
> you can go ahead and install.

Regarding the default completing-read-function, the prompt of 'C-u C-x v I'
doesn't provide completion on remote names.  Maybe this should be improved
as well.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]