bug#50370: Fix bug in ispell-init-process error handling

[Eli Zaretskii]

[Please use Reply All to keep the bug address on the CC list.]

> Date: Sat, 4 Sep 2021 11:33:42 -0700
> From: Ian W <ian@wahbe.com>
> 
> I think it’s a better error message, but that is just my opinion. It tells me 
> that ispell is trying to read an invalid
> dictionary file. In my case, I deleted that file and everything started 
> working. I also think it’s the error message
> intended to be displayed (by the ispell program and ispell package), as it is 
> the error message designed to
> help the user solve their problem.
> 
> (t
>  ;; Otherwise, it must be an error message. Show the user.
>  ;; But first wait to see if some more output is going to arrive.
>  ;; Otherwise we get cool errors like "Can't open ".
>  (sleep-for 1)
>  (ispell-accept-output 3) ;; <<< This is the line that errors >>>
>  (error "%s" (mapconcat #'identity ispell-filter "\n"))))
> 
> So the intended error message is never displayed. 
> 
> I’m sorry for not including a repo. I got it consistently because I had a bad 
> file cached by aspell (or maybe
> doom). You also get the same message when you didn’t install your 
> dictionaries correctly. This is a problem
> in how ispell displays errors, so it’s consistent but only if you already had 
> a real problem with ispell.
> 
> To repo:
> (setq ispell-local-dictionary-overridden t
>           ispell-local-dictionary "not-a-dict")
> 
> This misconfigures your local dictionary, and ensures that the ispell process 
> will error on start. Then run
> ispell-word on any word. Thanks for the prompt response. 

With the above recipe, I get:

  ispell-phaf: No matching entry for not-a-dict in 
‘ispell-hunspell-dict-paths-alist’.

(My speller is Hunspell.)

So does this mean this problem doesn't happen with Hunspell?  Ir is
the recipe incomplete or something?