bug#50435: 27.2; browse-url-encode-url not encoding spaces

[Lars Ingebrigtsen]

Howard Melman <hmelman@gmail.com> writes:

> I may be misunderstanding something, but
> browse-url-encode-url does not encode spaces.
>
>     (browse-url-encode-url "foo bar")
>
> returns "foo bar" and I think it should return "foo%20bar"
>
> It looks like a simple typo in browse-url-encode-url since it calls:
>
>   (browse-url-url-encode-chars url "[\")$] "))
>
> I think the space should be before the ], but from what I can 
> tell it's been that way since 2012.

browse-url-url-encode-chars was documented to take a string of
characters to translate, but used it as a regexp.  I've now fixed the
documentation and `browse-url-encode-url'.

> Also browse-url-encode-url is used in several browser
> specific browse-url functions like browse-url-netscape and
> browse-url-firefox but not in
> browse-url-default-windows-browser and
> browse-url-default-macosx-browser.  Is this intentional?
> I'm on a mac (using the macport) and it seems frustrating.

I've now fixed this in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no