bug#50667: Update ecomplete when used via standard UI

[Lars Ingebrigtsen]

Augusto Stoffel <arstoffel@gmail.com> writes:

> If one keeps sets
>
>     (setq message-mail-alias-type nil ;; or keep the default 'abbrev
>           message-expand-name-standard-ui t)
>
> and an ecomplete database file, then everything works OOTB,

Works in what way?

> except that the ecomplete database doesn't get updated with new
> addresses.
>
> Is the following change a reasonable fix for this?

[...]

> -      (when (and (message-mail-alias-type-p 'ecomplete)
> +      (when (and (bound-and-true-p ecomplete-database)

I think this would be highly surprising behaviour -- just loading a
library shouldn't have such side effects.

What's your use case here?  You don't want to use ecomplete for alias
expansions, but you still want to update the ecomplete database?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no