bug#50581: 27.2.50; Tramp fails to (un)compress directories

[Michael Albinus]

Tino Calancha <tino.calancha@gmail.com> writes:

Hi Tino,

>> Indeed, the directory case is not implemented in 
>> tramp-sh-handle-dired-compress-file.
>> I will see how to implement it next time.
>
> I have mimic what `dired-compress-file' does: it checks if the
> file is a directory.

Thanks, your patch looks good to me. And the two test functions work in
general.

Just some few comments:

> --- a/test/lisp/net/tramp-tests.el
> +++ b/test/lisp/net/tramp-tests.el
> +(ert-deftest tramp-test47-dired-compress-file ()

Please give it another name, which comes lexically before
tramp-test46-unload. That test must be the last one, because it unloads
Tramp in batch mode.

I recommend tramp-test44-dired-compress-file.

> +  "Check that Tramp (un)compress normal files."

"compresses"

> +  (skip-unless (tramp--test-enabled))

Add also

  (skip-unless (tramp--test-sh-p))

This is the only backend which implements dired-compress-file.

> +(ert-deftest tramp-test47-dired-compress-dir ()

Same comments.

If you like you could push it to Emacs, I will run then the zillions of
test configurations I have available locally.

Thanks, and best regards, Michael.