[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50179: [WIP PATCH v3] Add support for "bright" ANSI colors to ansi-c
From: |
Lars Ingebrigtsen |
Subject: |
bug#50179: [WIP PATCH v3] Add support for "bright" ANSI colors to ansi-color and term-mode |
Date: |
Wed, 22 Sep 2021 21:49:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Jim Porter <jporterbugs@gmail.com> writes:
> I don't quite know what to do about man.el though. It has overrides
> for a few of the faces used by ansi-color. I could maintain that
> behavior fairly easily, but maybe it makes sense to have it use the
> defaults from ansi-color.
Hm... I wonder why man.el is overriding the colours?
Skimming the patch, it looks good to me, but some trivial comments:
> -(defcustom ansi-color-faces-vector
> - [default bold default italic underline success warning error]
Instead of removing the variable, mark it as obsolete instead. (Users
may have code that references it in their .emacs files, and that
shouldn't bug out.)
> +(defconst ansi-color-basic-faces-vector
> + [nil
[...]
> - :type '(vector face face face face face face face face)
> - :set 'ansi-color-map-update
> - :initialize 'custom-initialize-default
> - :group 'ansi-colors)
Needs a :version.
> -(defcustom ansi-color-names-vector
> - ["black" "red3" "green3" "yellow3" "blue2" "magenta3" "cyan3" "gray90"]
Same thing with obsoletion here.
> -(defvar Man-ansi-color-map (let ((ansi-color-faces-vector
> - [ default Man-overstrike default Man-underline
> - Man-underline default default Man-reverse
> ]))
> - (ansi-color-make-color-map))
> - "The value used here for `ansi-color-map'.")
And same obsoletion thing here.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no