[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15809: [External] : Re: bug#15809: 24.3.50; wrong defcustom type for
From: |
Drew Adams |
Subject: |
bug#15809: [External] : Re: bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings' |
Date: |
Sat, 25 Sep 2021 15:22:00 +0000 |
> >> How about the attached?
> >
> > In some cases you say "must", in other cases you say "should".
>
> This inconsistency is there in the documentation already, compare:
> :type-error "This field should contain an integer"
> With:
> @item integer
> The value must be an integer.
>
> Sorting it out seems beyond the scope of this bug report. If we even
> need to do anything about it.
(FWIW)
I'm not asking that you fix this throughout Emacs.
I'm asking you to DTRT for this bug fix, i.e., for
this defcustom.
> > You could say that one can always assign an option a value
> > that doesn't match its :type spec. So in practice, there's
> > no solid enforcement of the law. Still, the law says the
> > value must be a nonnegative integer, regardless of whether
> > there are ways to escape enforcement. It's the law that
> > gets written as the rule. ;-)
>
> I basically agree, but we use "must" and "should" interchangeably all
> over Emacs. In context, they mean more or less the same thing.
Just because there are bugs elsewhere is no reason
to create new, similar bugs.
There's a real, big difference between "must" and
"should". And in general "should" is a weasel word
and "should" ;-) be avoided in technical doc.
In the case of :type, there's no ambiguity or room
for waffling (except what I mentioned - if you use
the Customize UI there's no room at all). The right
word to use for this is "must".
bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings', Mattias Engdegård, 2021/09/25
bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings', Mattias Engdegård, 2021/09/25
bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings', Stefan Kangas, 2021/09/25
bug#15809: [External] : Re: bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings', Drew Adams, 2021/09/25