bug#40750: [External] : bug#40750: Use error face for errors

[Stefan Kangas]

Drew Adams <drew.adams@oracle.com> writes:

> Add a user option, defaulting to no change from
> the traditional behavior, which causes error and
> warning messages to preserve text properties on
> the strings they use.

That's not what happens, see Bug#50785.

> Code should be able to control the appearance
> of text it uses when interacting with users.
> And users should be able to override this or
> (better) configure it.

Having a face is exactly the way to give users control over what this
looks like.

Of course, the error face should not just remove any faces that are
already there; that precludes making e.g. keybindings stand out with the
`help-key-binding' face.  So you would need to give the error-message
face lower priority.