bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#51012: 29.0.50; Problems with emojis and vertical-motion


From: Robert Pluim
Subject: bug#51012: 29.0.50; Problems with emojis and vertical-motion
Date: Mon, 04 Oct 2021 19:08:05 +0200

>>>>> On Mon, 04 Oct 2021 20:04:50 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Mon, 04 Oct 2021 18:43:53 +0200
    >> Cc: 51012@debbugs.gnu.org
    >> 
    >> This fixes it for me:
    >> 
    >> diff --git a/src/font.c b/src/font.c
    >> index 82a1dffc01..83f0f8296a 100644
    >> --- a/src/font.c
    >> +++ b/src/font.c
    >> @@ -3918,7 +3918,7 @@ font_range (ptrdiff_t pos, ptrdiff_t pos_byte, 
ptrdiff_t *limit,
    >> val = XCAR (val);
    >> else if (VECTORP (val))
    >> val = AREF (val, 0);
    >> -          font_object = font_for_char (face, XFIXNAT (val), pos - 1, 
string);
    >> +          font_object = font_for_char (face, XFIXNAT (val), pos, 
string);
    >> }
    >> }

    Eli> Sounds obvious to me.  Why was there a minus there in the first place?
    Eli> some remnant of debugging or the previous version?

The previous version ran that code after pos had been incremented. So
when I moved it up I forgot to undo the adjustment of 'pos'.

Robert
-- 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]