bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds

[Basil L. Contovounesios]

Severity: minor
Tags: patch

I see the following byte-compilation warnings in --without-x builds:

--8<---------------cut here---------------start------------->8---
In edmacro-fix-menu-commands:
edmacro.el:622:34: Warning: reference to free variable
    ‘mouse-wheel-down-event’
edmacro.el:622:57: Warning: reference to free variable ‘mouse-wheel-up-event’
edmacro.el:623:34: Warning: reference to free variable
    ‘mouse-wheel-right-event’
edmacro.el:624:34: Warning: reference to free variable
    ‘mouse-wheel-left-event’

In end of data:
mh-e/mh-compat.el:96:5: Warning: the function ‘image-search-load-path’ is not
    known to be defined.
mh-e/mh-compat.el:93:5: Warning: the function ‘image-load-path-for-library’ is
    not known to be defined.
In mh-logo-display:
mh-e/mh-utils.el:129:40: Warning: Unused lexical variable `image-load-path'
In mh-tool-bar-folder-buttons-init:
mh-e/mh-tool-bar.el:302:1: Warning: Unused lexical variable `image-load-path'
In mh-tool-bar-letter-buttons-init:
mh-e/mh-tool-bar.el:384:3: Warning: Unused lexical variable `image-load-path'
In end of data:
mh-e/mh-utils.el:128:24: Warning: the function ‘image-load-path-for-library’
    is not known to be defined.
In end of data:
mh-e/mh-tool-bar.el:302:1: Warning: the function ‘image-load-path-for-library’
    is not known to be defined.
--8<---------------cut here---------------end--------------->8---

The MH-E warnings are seen on master, whereas the edmacro ones are also
on emacs-28 (details of both configurations follow my signature).

I assume the warnings are not important enough to install anything on
emacs-28, so I attach a patch against master for both sets of warnings.
WDYT?

Thanks,

-- 
Basil

0001-Fix-byte-compilation-warnings-in-nox-builds.patch
Description: Text Data

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
 of 2021-10-11 built on tia
Repository revision: 2810fe6bfca182e4376d818b5510507d5ff7e1b5
Repository branch: master
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --program-suffix=-nox
 --enable-checking=structs --with-file-notification=yes
 --with-x-toolkit=no --without-x'

Configured features:
ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm gv subr-x
byte-opt bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc
paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese composite
emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 multi-tty make-network-process
emacs)

In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu)
 of 2021-10-11 built on tia
Repository revision: b3d0f53b296a0876ec7a55ae840868e65ed54e14
Repository branch: emacs-28
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --program-suffix=-28-nox
 --enable-checking=structs --with-file-notification=yes
 --with-x-toolkit=no --without-x'

Configured features:
ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv
bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese composite
emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 multi-tty make-network-process
emacs)