bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key


From: Eli Zaretskii
Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key
Date: Wed, 20 Oct 2021 14:28:42 +0300

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: stefan@marxist.se,  shuguang79@qq.com,  50752@debbugs.gnu.org
> Date: Tue, 19 Oct 2021 20:21:42 +0200
> 
> > uniprop_table is somewhat expensive, and is definitely an overkill for
> > converting pure ASCII characters.  Why not just set/reset the 0x20
> > bit?
> 
> I thought it made sense to be conservative here and do it "properly",
> instead of open-coding an A-Za-z upcase/downcase ourselves.

Why is it a problem to do it ourselves?  It's a simple and very
efficient operation, and it will always be correct.

> And doesn't
> uniprop_table just return the table from char-code-property-alist here?
> So it's an assq from a short list.

It returns a char-table (so not really a short list), and it loads a
file when first called.  It isn't incorrect, just too heavy for such a
simple job.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]