bug#44733: Nested let bindings for non-local DEFVAR_PER_BUFFER variables unwind wrong

[Stefan Kangas]

close 44733 28.1
thanks

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I just pushed a fix for that, along with the corresponding test case,

It seems like this was fixed but never closed, so I'm closing it now.

commit 8fac2444641567b10f4c38b599636aeae0478e68
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Thu Nov 19 17:13:04 2020 -0500

    * src/data.c (set_internal): Fix bug#44733

    Set the default value when `set` encounters a PER_BUFFER variable
    which has been let-bound globally, to match the behavior seen with
    `make-variable-buffer-local`.

    * test/src/data-tests.el (binding-test--let-buffer-local):
    Add corresponding test.
    (data-tests--set-default-per-buffer): Add tentative test for the
    performance problem encountered in bug#41029.